Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor UiaTextRange For Improved Navigation and Reliability #4018

Merged
24 commits merged into from
Jan 31, 2020
Merged

Refactor UiaTextRange For Improved Navigation and Reliability #4018

24 commits merged into from
Jan 31, 2020

Commits on Dec 18, 2019

  1. utr refactor

    @carlos-zamora
    carlos-zamora committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    719676c View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. Refactor UiaTextRange: 

    - remove _degenerate
- _start and _end are now COORDs
- _end is always exclusive
- de-static-fy functions
- all COORDs are in the text buffer coordinate system
    @carlos-zamora
    carlos-zamora committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    e7555dc View commit details
    Browse the repository at this point in the history

  2. remove accidental file

    @carlos-zamora
    carlos-zamora committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    76a26e3 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. Add accessibilityMode to GetWordStart/End and Viewport functions. 

    Get some tests running again
    @carlos-zamora
    carlos-zamora committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    d4c4e29 View commit details
    Browse the repository at this point in the history

  2. Testing!!!!

    @carlos-zamora
    carlos-zamora committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    3017aaa View commit details
    Browse the repository at this point in the history

  3. wtvr

    @carlos-zamora
    carlos-zamora committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    f6b2ea2 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2019

  1. Let's try doing word nav this way

    Carlos Zamora committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    9a40869 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2020

  1. Add testing for Compare, CompareEndpoint, Expand, and MoveEndpointByR… 

    …ange

Missing tests for...
- GetText
- Move
- MoveEndpointByUnit
Still need to think of how to approach Move and MoveEndpointByUnit since these should be very similar and should reuse a lot of code.
    @carlos-zamora
    Carlos Zamora authored and carlos-zamora committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    ea22c8f View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. Turns out, the bug is in our wrapper class. Not supposed to return nu… 

    …llptr when attribute not found. Don't know why this is an issue _now_
    @carlos-zamora
    carlos-zamora committed Jan 22, 2020
    3 Configuration menu
    Copy the full SHA
    bcfc522 View commit details
    Browse the repository at this point in the history

  2. - Code format 

    - disable debug log
    @carlos-zamora
    carlos-zamora committed Jan 22, 2020
    Configuration menu
    Copy the full SHA
    71d50cb View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2020

  1. Finish fixing NVDA issues with UiaTextRange (scoped for this PR) 

    Narrator's word navigation has regressed. This PR will not be ready until that is fixed.
    @carlos-zamora
    carlos-zamora committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    c075ab2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into dev/cazamor/utr-refactor-1

    @carlos-zamora
    carlos-zamora committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    d11a7b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2020

  1. Good amount of PR Changes

    @carlos-zamora
    carlos-zamora committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    9ee0d72 View commit details
    Browse the repository at this point in the history

  2. A few dumb errors on my part

    @carlos-zamora
    carlos-zamora committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    e44db54 View commit details
    Browse the repository at this point in the history

  3. Polish non-testing area. Up next: testing polish

    @carlos-zamora
    carlos-zamora committed Jan 30, 2020
    5 Configuration menu
    Copy the full SHA
    4571d42 View commit details
    Browse the repository at this point in the history

  4. Polish tests

    @carlos-zamora
    carlos-zamora committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    1e9cf75 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2020

  1. static analysis fixes

    @carlos-zamora
    carlos-zamora committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    7bcfa72 View commit details
    Browse the repository at this point in the history

  2. whoops! missed a const!

    @carlos-zamora
    carlos-zamora committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    706620c View commit details
    Browse the repository at this point in the history

  3. pass SA

    @carlos-zamora
    carlos-zamora committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    f676af3 View commit details
    Browse the repository at this point in the history

  4. dead code

    @carlos-zamora
    carlos-zamora committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    d21fbdf View commit details
    Browse the repository at this point in the history

  5. fix the build!!

    @carlos-zamora
    carlos-zamora committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    1caf2ca View commit details
    Browse the repository at this point in the history

  6. Dustin's PR Comments + added noexcepts

    @carlos-zamora
    carlos-zamora committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    f8e0548 View commit details
    Browse the repository at this point in the history

  7. added comments about my pain

    @carlos-zamora
    carlos-zamora committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    306013f View commit details
    Browse the repository at this point in the history

  8. wrong parameter name

    @carlos-zamora
    carlos-zamora committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    25de3ed View commit details
    Browse the repository at this point in the history