Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx: don't check the OS version multiple times #3480

Merged

Conversation

skyline75489
Copy link
Collaborator

Summary of the Pull Request

A tiny little perf fix.

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

I don't really get it, though. Isn't Windows Terminal only available on Windows 10+?

Validation Steps Performed

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this looks simple enough to me. Thanks!

@zadjii-msft
Copy link
Member

I don't really get it, though. Isn't Windows Terminal only available on Windows 10+?

We recently added the WPF version of the TermControl (in #2004). That control isn't used in the Windows Terminal, but does share a lot of code (including the DXRenderer). It's not necessarily bound to the same Windows 10 requirement that the rest of the Terminal is 😄

Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess the OS version won't be changing at runtime eh?

@DHowett-MSFT DHowett-MSFT changed the title Don't check OS version for multiple times in DX renderer dx: don't check the OS version multiple times Nov 8, 2019
@DHowett-MSFT DHowett-MSFT merged commit c274b38 into microsoft:master Nov 8, 2019
@skyline75489 skyline75489 deleted the fix/detectWindowsVersion branch February 9, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants