Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix win key resets scroll location #2514

Merged
merged 3 commits into from
Aug 23, 2019
Merged

Fix win key resets scroll location #2514

merged 3 commits into from
Aug 23, 2019

Conversation

marcelfreiberg
Copy link
Contributor

Summary of the Pull Request

Checking if a windows key is pressed and prevent handling at all.

PR Checklist

  • Closes Win-Key resets scroll location #2506
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  1. Run commands until the scroll bar appears
  2. Scroll up
  3. Press the windows key

The terminal should not reset the scroll location

This is my very first pull request on GitHub. Please be kind 😃

@DHowett-MSFT
Copy link
Contributor

Thanks for doing this! It might be better for us to handle it up in TermControl's PreviewKeyDown handler -- @zadjii-msft, what do you think?

@marcelfreiberg
Copy link
Contributor Author

@DHowett-MSFT this seems reasonable to me. I will change the logic

DHowett-MSFT
DHowett-MSFT approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it.

@DHowett-MSFT DHowett-MSFT added the Needs-Second It's a PR that needs another sign-off label Aug 23, 2019
@ghost ghost requested review from zadjii-msft, miniksa and carlos-zamora August 23, 2019 00:14
zadjii-msft
zadjii-msft approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, thanks!

@DHowett-MSFT DHowett-MSFT merged commit 02d8df8 into microsoft:master Aug 23, 2019
@DHowett-MSFT
Copy link
Contributor

Thanks for the contribution!

@marcelfreiberg marcelfreiberg deleted the freib98/fix-win-key-handling branch August 23, 2019 18:00
@ghost
Copy link

ghost commented Aug 27, 2019

🎉Windows Terminal Preview v0.4.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

Assignees
No one assigned
Labels
Needs-Second It's a PR that needs another sign-off
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Win-Key resets scroll location
3 participants
@marcelfreiberg @DHowett-MSFT @zadjii-msft