Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to apply the theme on load of the application #2107

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

zadjii-msft
Copy link
Member

Fixes #1913.

_AplyTheme raises an event for the IslandWindow to handle and actually apply
the theme, so we don't really need to worry about it, but we do need to
worry for ContentDialogs.

PR Checklist

  Fixes #1913.

  _AplyTheme raises an event for the IslandWindow to handle and actually apply
  the theme, so we don't _really_ need to worry about it, but we do need to
  worry for ContentDialogs.
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Jul 25, 2019
@zadjii-msft zadjii-msft requested a review from a team July 25, 2019 19:52
@miniksa miniksa merged commit a574685 into master Jul 25, 2019
@miniksa miniksa deleted the dev/migrie/b/1913-theme-on-load branch July 25, 2019 20:25
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 26, 2019
Fixes microsoft#1913.

  _AplyTheme raises an event for the IslandWindow to handle and actually apply
  the theme, so we don't _really_ need to worry about it, but we do need to
  worry for ContentDialogs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Dark Theme requires settings reload
3 participants