Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate entries from defaults.json #18527

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Remove duplicate entries from defaults.json #18527

merged 1 commit into from
Feb 12, 2025

Conversation

joca-bt
Copy link
Contributor

@joca-bt joca-bt commented Feb 7, 2025

  • Remove duplicated entries.
  • Fix whitespace.

@joca-bt
Fixes to defaults.json
47e6fbe 
- Remove duplicated entries.
- Fix whitespace.
DHowett
DHowett approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, it's strange that we had duplicates. I suspect during the transition from actions to keys + actions we accidentally left some actions for which we had had duplicated keys.

Thanks!

@DHowett
Copy link
Member

DHowett commented Feb 7, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joca-bt
Copy link
Contributor Author

joca-bt commented Feb 11, 2025

@DHowett how do I assign more reviewers to this PR? It requires 2 approves but only 1 reviewer is assigned.

carlos-zamora
carlos-zamora approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this 😊

@carlos-zamora carlos-zamora changed the title Fixes to defaults.json Remove duplicate entries from defaults.json Feb 12, 2025
@carlos-zamora carlos-zamora merged commit b8ff95d into microsoft:main Feb 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joca-bt @DHowett @carlos-zamora