wsl: skip distributions that indicate they are "Modern" #18183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
commented
Nov 12, 2024
| @@ -188,6 +189,12 @@ static bool getWslNames(const wil::unique_hkey& wslRootKey, | |||
| continue; | |||
| } | |||
|
|
|||
| const auto modernValue{ wil::reg::try_get_value<uint32_t>(distroKey.get(), RegKeyModern) }; | |||
| if (modernValue == 1u) | |||
There was a problem hiding this comment.
it's an optional - nullopt is != 1 :)
There was a problem hiding this comment.
I'd prefer if this was .value_or(0) != 0 because that would more accurately represent "truthy".
OneBlue
approved these changes
Nov 12, 2024
carlos-zamora
approved these changes
Nov 13, 2024
DHowett
added a commit
that referenced
this pull request
Nov 15, 2024
(cherry picked from commit 00ff803) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgUu4sc Service-Version: 1.21
DHowett
added a commit
that referenced
this pull request
Nov 15, 2024
(cherry picked from commit 00ff803) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgUu4sg Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.