-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add miscellaneous simple settings to the settings UI #17923
base: main
Are you sure you want to change the base?
Conversation
@@ -1839,4 +1871,20 @@ | |||
<value>Non-monospace fonts:</value> | |||
<comment>This is a label that is followed by a list of proportional fonts.</comment> | |||
</data> | |||
<data name="Profile_RainbowSuggestions.Header" xml:space="preserve"> | |||
<value>Display suggestions UI preview text with rainbow formatting</value> | |||
<comment>This is a label for a setting that, when enabled, applies a rainbow coloring to the previewable text from the suggestions UI.</comment> |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
0c7979c
to
c895a73
Compare
This comment was marked as resolved.
This comment was marked as resolved.
<!-- Enable Unfocused Acrylic --> | ||
<local:SettingContainer x:Uid="Globals_EnableUnfocusedAcrylic"> | ||
<ToggleSwitch IsOn="{x:Bind ViewModel.EnableUnfocusedAcrylic, Mode=TwoWay}" | ||
Style="{StaticResource ToggleSwitchInExpanderStyle}" /> | ||
</local:SettingContainer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that this setting is compatibility.enableUnfocusedAcrylic
. Any ideas why it's in the compatibility namespace? To me, it makes sense to have in the appearance page, but the compatibility
namespace is making me second guess that it should be in the new compatibility page. Should we remove the compatibility
prefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was more "OS compatibility" - unfocused acrylic is actually a different implementation of acrylic than usual. It has caused some issues in the past.
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
c895a73
to
76b17f9
Compare
Summary of the Pull Request
Adds the following settings to the settings UI:
Additionally, the following settings have graduated from experimental 🎓:
Part of #10000