Restore contents when a screen info is closed #17853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
lhecker
commented
Sep 3, 2024
Comment on lines
+804
to
+813
| if (oldSize != main.GetBufferSize().Dimensions()) | ||
| { | ||
| THROW_IF_NTSTATUS_FAILED(main.ResizeTraditional(oldSize)); | ||
| main.SetViewportSize(&oldSize); | ||
| } | ||
| if (hasAltBuffer && oldSize != alt.GetBufferSize().Dimensions()) | ||
| { | ||
| THROW_IF_NTSTATUS_FAILED(alt.ResizeTraditional(oldSize)); | ||
| alt.SetViewportSize(&oldSize); | ||
| } |
There was a problem hiding this comment.
These two blocks have changed slightly, to avoid reflow when the size hasn't changed (the common case I assume). All other code remains unchanged.
carlos-zamora
approved these changes
Sep 3, 2024
DHowett
approved these changes
Sep 6, 2024
DHowett
pushed a commit
that referenced
this pull request
Sep 6, 2024
(cherry picked from commit 4eb06fe) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgSaylY Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
SetConsoleActiveScreenBufferImplintoVtIowhichallows us to use the code when the screen info handle is closed.
Closes #17817
Validation Steps Performed
CreateConsoleScreenBuffer+SetConsoleActiveScreenBufferCloseHandleresults in no obvious screen changes ✅