Add action IDs to the color selection commands #17821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
carlos-zamora
approved these changes
Aug 29, 2024
zadjii-msft
approved these changes
Aug 29, 2024
|
Marked up for 1.22 - thanks for the report and for the quick fix! |
DHowett
reviewed
Sep 4, 2024
| @@ -364,7 +403,8 @@ | |||
| "foreground": "i00", | |||
| "background": "i03" | |||
| }, | |||
| "keys": "ctrl+shift+0" | |||
| "keys": "ctrl+shift+0", | |||
There was a problem hiding this comment.
Hey, does having keys, command and id in the same settings file -- even though it is a SYSTEM settings file -- result in us changing the user's keys list? (e.g. do we accidentally up-convert these key/command/id triples into key/id and action/id pairs?)
There was a problem hiding this comment.
We do convert these into key/id and action/id pairs in our internal maps, but they're still in the InBox layer so they don't show up in the user's settings file
DHowett
pushed a commit
that referenced
this pull request
Sep 4, 2024
## Summary of the Pull Request Add action IDs to the default commands for color selection ## Validation Steps Performed Color selection commands now show up in the command palette ## PR Checklist - [x] Closes #17819 - [ ] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary) (cherry picked from commit 1482fd4) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgSawsY PVTI_lADOAF3p4s4AmhmQzgSwIVc Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Add action IDs to the default commands for color selection
Validation Steps Performed
Color selection commands now show up in the command palette
PR Checklist