Add tab color indicator for tab switch menu (CTRL+Tab) #17820
Conversation
nukoseer
changed the title
nukoseer
force-pushed
the
dev/ctrl_tab_color_indicator
branch
from
c5e01b0
to
d25e78b
Compare
| @@ -205,6 +205,13 @@ | |||
| Visibility="{x:Bind Item.(local:TabPaletteItem.TabStatus).IsInputBroadcastActive, Mode=OneWay}" /> | |||
|
|
|||
| </StackPanel> | |||
|
|
|||
| <Ellipse Grid.Column="4" | |||
There was a problem hiding this comment.
Slightly worried that this will overlap with the scrollbar on the tab picker if there's a lot of tabs. Who knows - maybe that column was vestigial?
There was a problem hiding this comment.
It kind of overlaps, but it doesn't seem like a big problem to me 😅
src/cascadia/TerminalApp/TabBase.cpp
Outdated
| { | ||
| const auto currentColor = GetTabColor(); | ||
|
|
||
| if (currentColor.has_value()) |
There was a problem hiding this comment.
IIRC this if/else could probably just be a single .value_or(Windows::UI::Colors::Transparent())
|
I love this so much! Thanks for doing it! 😄 |
There was a problem hiding this comment.
Hey, I did just realize that we have TabPaletteItem specifically for things like this. You can see where it's used by finding its members IsReadOnlyActive and IsInputBroadcastActive.
I was feeling a little weird about it being on the generic PaletteItem, because that's also used for commands. I'm thinking that it might feel better on TabPaletteItem!
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
nukoseer
force-pushed
the
dev/ctrl_tab_color_indicator
branch
from
eccf7c9
to
1845601
Compare
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
I removed |
Added tab color indicator for the tab switch menu. Tab color indicators have the same color as the background color of the tabs. If a tab has the default background color, the indicator is not shown in the tab switch menu. Closes #17465 (cherry picked from commit 544452d) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgS0CZA Service-Version: 1.22
Added tab color indicator for the tab switch menu. Tab color indicators have the same color as the background color of the tabs. If a tab has the default background color, the indicator is not shown in the tab switch menu.
I don't know if it was a good idea, but I just used small circles for indicators.
Relevant issue(s); #17465
20240828_231729.mp4