Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the new and beautiful VS Dev Shell icons #17706

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Aug 12, 2024

We got some new icons for Developer Command Prompt and Developer PowerShell from our friends over on Visual Studio!

This pull request includes them in the package, and fixes up the VS dynamic profiles to reset any icons that matched the old paths.

This may be a minor breaking change for user settings, but we're making the assumption that if they didn't change their VS profile icons from the defaults, they probably want to follow us to the new defaults.

To prevent anything like this from happening again, we're going to stop serializing icons for stub profiles.

I've also included a VS version of the PowerShell "black" icon which is currently unused, but can be used in the future for PS7+-based VS Dev Shell.

Closes #17627

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Aug 12, 2024
@stamminator
Copy link

Will these icons apply to Terminal profiles for older installations of Visual Studio, like 2019 or 2017? It may be fine to use the 2022 icons for all of them, but it's worth noting.

@DHowett
Copy link
Member Author

DHowett commented Aug 13, 2024

Will these icons apply to Terminal profiles for older installations of Visual Studio, like 2019 or 2017? It may be fine to use the 2022 icons for all of them, but it's worth noting.

For now, they will. They'll also be used for Preview even though the VS logo differs between Stable and Preview. However, this pull request also sets us up to change them in the future without having to break user settings. 🙂

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShipitSquirrelGIF

@DHowett DHowett merged commit 06c07ab into main Aug 13, 2024
20 checks passed
@DHowett DHowett deleted the dev/duhowett/vsi branch August 13, 2024 23:21
@DHowett
Copy link
Member Author

DHowett commented Aug 13, 2024

/cc @zadjii-msft we made the explicit choice to stop serializing icon for generated profiles. gives us more freedom, as well as fragment authors

DHowett added a commit that referenced this pull request Aug 20, 2024
We got some new icons for Developer Command Prompt and Developer
PowerShell from our friends over on Visual Studio!

This pull request includes them in the package, and fixes up the VS
dynamic profiles to reset any icons that matched the old paths.

This may be a minor breaking change for user settings, but we're making
the assumption that if they didn't change their VS profile icons from
the defaults, they probably want to follow us to the new defaults.

To prevent anything like this from happening again, we're going to stop
serializing icons for stub profiles.

I've also included a VS version of the PowerShell "black" icon which is
currently unused, but can be used in the future for PS7+-based VS Dev
Shell.

Closes #17627

(cherry picked from commit 06c07ab)
Service-Card-Id: 93531228
Service-Version: 1.20
DHowett added a commit that referenced this pull request Aug 20, 2024
We got some new icons for Developer Command Prompt and Developer
PowerShell from our friends over on Visual Studio!

This pull request includes them in the package, and fixes up the VS
dynamic profiles to reset any icons that matched the old paths.

This may be a minor breaking change for user settings, but we're making
the assumption that if they didn't change their VS profile icons from
the defaults, they probably want to follow us to the new defaults.

To prevent anything like this from happening again, we're going to stop
serializing icons for stub profiles.

I've also included a VS version of the PowerShell "black" icon which is
currently unused, but can be used in the future for PS7+-based VS Dev
Shell.

Closes #17627

(cherry picked from commit 06c07ab)
Service-Card-Id: 93531229
Service-Version: 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
Status: Cherry Picked
Development

Successfully merging this pull request may close these issues.

Better icons for Visual Studio Developer Command Prompt/Powershell profiles
4 participants