-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A shortcut to select file/files in the explorer. And copy that path to the terminal. #16966
base: main
Are you sure you want to change the base?
Conversation
…ble, can't check for wsl yet)
@microsoft-github-policy-service agree |
Hey there! Sorry about the delay - we've got a couple vacations on the team and are working through a backlog. Thanks for your patience! |
Thats fine, vacation is important haha. |
I think visual studio has accidentally auto formatted some things. I already took it it out i thought. |
Has anyone started looking into this PR yet? |
My apologies, I've been meaning to get back to this sooner, but Build prep keeps coming up as interrupt-priority work. In terms of raw code feedback:
I have other big-picture thoughts that I want to have the team have another quick chat about, but that'll unfortunately have to wait until after Build at this point. Thanks for your patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(as noted)
I would rather it not be closed for these reasons. I don't have as much time now as i had two months ago when it was opened. I will make the changes but need to find some time for it. |
Summary of the Pull Request
A PR to add the functionality specified in #16965
It adds an shortcut, currently ctrl+o that open a file explorer dialog to select files.
When an file or files are selected the appropiate paths are pasted into the terminal.
It also takes in account if quotes are necessary. This is largely based on the same implementation that takes care of pasting paths for dragging and dropping into the terminal.
References and Relevant Issues
#16965
Detailed Description of the Pull Request / Additional comments
An pull request with code to implement #16965.
Known things that still have to be implemented is support for WSL. The code for WSL path support is there, however i was unable to find an function/variable to check if its in WSL context.
This is the code for wsl support. Where it says false there should be an bool called IsWsl.
The rest of the code is too take care of Path Mangling for WSL.
TerminalPage.cpp, Line 3005
Validation Steps Performed
PR Checklist