Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added selectionBackground to light color schemes #16243

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

TahaHaksal
Copy link
Contributor

@TahaHaksal TahaHaksal commented Oct 30, 2023

Add a selectionBackground property which is set to the scheme's brightBlack too all 3 of the light color schemes.

Related to #8716
It does not close the bug because as mentioned in the issue, when you input numbers, they seem to be invisible in the light color schemes and selecting them with the cursor doesn't reveal them.

@TahaHaksal
Copy link
Contributor Author

PS: This is my first PR to open-source projects. I've tried to follow contribution guidelines. If I made any mistakes along the way, I'm more than willing to accept any criticizm. Thanks in advance

@DHowett
Copy link
Member

DHowett commented Nov 6, 2023

Thanks so much for doing this!

We have a bug with our handling of color schemes that might cause a problem, but we can fix that.

The issue is that the color schemes you have changed get copied into the user's settings... so the changes in this file don't get applied to existing users.

We have a pull request out that improves this situation (#12800).

@DHowett DHowett changed the title Added selectionBackground to light color schemes (microsoft#8716) Added selectionBackground to light color schemes Nov 6, 2023
@DHowett DHowett merged commit a5c269b into microsoft:main Nov 6, 2023
14 checks passed
@TahaHaksal
Copy link
Contributor Author

Thank you for the feedback, can't wait to contribute more to the project in the future. (If I can find an issue fit for my skills that is.)

@TahaHaksal TahaHaksal deleted the selectionBackground branch November 6, 2023 22:57
DHowett pushed a commit that referenced this pull request Nov 7, 2023
Add a selectionBackground property which is set to the scheme's
brightBlack too all 3 of the light color schemes.

Related to #8716
It does not close the bug because as mentioned in the issue, when you
input numbers, they seem to be invisible in the light color schemes and
selecting them with the cursor doesn't reveal them.

(cherry picked from commit a5c269b)
Service-Card-Id: 91033166
Service-Version: 1.18
DHowett pushed a commit that referenced this pull request Nov 7, 2023
Add a selectionBackground property which is set to the scheme's
brightBlack too all 3 of the light color schemes.

Related to #8716
It does not close the bug because as mentioned in the issue, when you
input numbers, they seem to be invisible in the light color schemes and
selecting them with the cursor doesn't reveal them.

(cherry picked from commit a5c269b)
Service-Card-Id: 91033167
Service-Version: 1.19
DHowett pushed a commit that referenced this pull request Nov 7, 2023
Add a selectionBackground property which is set to the scheme's
brightBlack too all 3 of the light color schemes.

Related to #8716
It does not close the bug because as mentioned in the issue, when you
input numbers, they seem to be invisible in the light color schemes and
selecting them with the cursor doesn't reveal them.

(cherry picked from commit a5c269b)
Service-Card-Id: 91033166
Service-Version: 1.18
radu-cernatescu pushed a commit to radu-cernatescu/terminal that referenced this pull request Nov 8, 2023
Add a selectionBackground property which is set to the scheme's
brightBlack too all 3 of the light color schemes.

Related to microsoft#8716
It does not close the bug because as mentioned in the issue, when you
input numbers, they seem to be invisible in the light color schemes and
selecting them with the cursor doesn't reveal them.
DHowett added a commit that referenced this pull request Jan 12, 2024
- AtlasEngine: Minor bug fixes (GH-16219)
- Fix the fix for the fix of nearby font loading (GH-16196)
- Added selectionBackground to light color schemes (GH-16243)
- Another theoretical fix for a crash (GH-16267)
- Fix tabs being printed in cmd.exe prompts (GH-16273)

Related work items: MSFT-47266988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants