Don't update the settings, unless the theme actually changed #16004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
lhecker
approved these changes
Sep 19, 2023
carlos-zamora
approved these changes
Sep 20, 2023
carlos-zamora
deleted the
dev/migrie/b/15732-more-precise-OS-theme-reloading
branch
DHowett
pushed a commit
that referenced
this pull request
Sep 22, 2023
`ImmersiveColorSet` gets sent more often than just on a theme change. It notably gets sent when the PC is locked, or the UAC prompt opens. ## Validation Steps Performed Tested manually by setting the font to `garbo`and: * locking, then logging back in. No dialog ✅ * UAC via run dialog + `regedit`. No dialog ✅ * Actually changing the OS theme. Dialog ✅ Closes #15732 (cherry picked from commit c1bdcf8) Service-Card-Id: 90600308 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImmersiveColorSetgets sent more often than just on a theme change. It notably gets sent when the PC is locked, or the UAC prompt opens.Validation Steps Performed
Tested manually by setting the font to
garboand:regedit. No dialog ✅