Add UIA element grouping to SettingsContainer #15756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
lhecker
approved these changes
Jul 25, 2023
|
Wait, though. Does this not have anything to do with our actual groupings? 
Do we have an affordance for that? What does that look like to a screen reader? |
|
I guess it's not related to the bug report so it's not a problem, but I am curious! |
|
Yeah! I tried doing a similar thing for those groupings and I couldn't get it to work. Figured it's not related to the bug report so yeah, not a problem haha. To be clear, I tried adding an AutomationProperties.Name to the StackPanel with a |
|
Fair enough! |
DHowett
pushed a commit
that referenced
this pull request
Jul 27, 2023
Adds an `AutomationProperty.Name` to the main grid in the `SettingContainer`. Doing so makes it so that the group of elements is considered a "group \<header\>". Now, when navigating with a screen reader, when you enter the group of elements, the "group \<header\>" will be presented. Thus, if the user navigates to the "reset" button, it'll be prefaced with a "group \<header\>" announcement first. If the user navigates to it from the other direction (the setting control), this announcement isn't made, but the user already has an understanding of what group of settings they're in, which is standard practice. Closes #15158 (cherry picked from commit d70794a) Service-Card-Id: 89990838 Service-Version: 1.17
DHowett
pushed a commit
that referenced
this pull request
Jul 27, 2023
Adds an `AutomationProperty.Name` to the main grid in the `SettingContainer`. Doing so makes it so that the group of elements is considered a "group \<header\>". Now, when navigating with a screen reader, when you enter the group of elements, the "group \<header\>" will be presented. Thus, if the user navigates to the "reset" button, it'll be prefaced with a "group \<header\>" announcement first. If the user navigates to it from the other direction (the setting control), this announcement isn't made, but the user already has an understanding of what group of settings they're in, which is standard practice. Closes #15158 (cherry picked from commit d70794a) Service-Card-Id: 89990839 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
AutomationProperty.Nameto the main grid in theSettingContainer. Doing so makes it so that the group of elements is considered a "group <header>".Now, when navigating with a screen reader, when you enter the group of elements, the "group <header>" will be presented. Thus, if the user navigates to the "reset" button, it'll be prefaced with a "group <header>" announcement first. If the user navigates to it from the other direction (the setting control), this announcement isn't made, but the user already has an understanding of what group of settings they're in, which is standard practice.
Closes #15158