Properly filter focus events from the console API #15606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improved fix for #13238. Instead of handling focus events in
the
TerminalInput::HandleKey
function and the need to filter themout depending on where they came from, we simply don't call
HandleKey
in the first place. This makes the somewhat unreliable
CameFromApi
function unnecessary and the code a bit more robust.
This change is required because
CameFromApi
is not representablein a
INPUT_RECORD
and I'm getting rid ofIInputEvent
.Validation Steps Performed
[O
when exiting nvim ✅