A very sensible Pane refactoring #15232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
approved these changes
Apr 25, 2023
DHowett
reviewed
Apr 25, 2023
carlos-zamora
approved these changes
Apr 25, 2023
DHowett
reviewed
Apr 25, 2023
| winrt::event_token _connectionStateChanged{ 0 }; | ||
| winrt::event_token _warningBell{ 0 }; | ||
| winrt::event_token _closeTerminalRequested{ 0 }; | ||
| winrt::Microsoft::Terminal::Control::TermControl::ConnectionStateChanged_revoker _ConnectionStateChanged; |
There was a problem hiding this comment.
minor nit: we should avoid _Uppercase in new code
There was a problem hiding this comment.
I have half a mind for some sort of xmacro / til template for stuff like this. There's now a collection of places where we're all setting up revokers like this. Like, there's gotta be a better way.... Anywho, this was me being preemptive, which is not always warranted
zadjii-msft
added
AutoMerge
microsoft-github-policy-service
bot
deleted the
dev/migrie/eim/sensible-pane-chuckle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seemed dangerous to just have places all over Pane where we manipulate the whole cadre of TermControl events. Seemed ripe for a copypasta error. This moves that around, so there's only two methods for messing with the TermControl callbacks:
_setupControlEventsand_removeControlEvents.Closes: nothing. This was an off-the-cuff commit that seemed valuable.