Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reword en-US value for confirmCloseAllTabs #14473

Merged
merged 2 commits into from
Dec 9, 2022
Merged

reword en-US value for confirmCloseAllTabs #14473

merged 2 commits into from
Dec 9, 2022

Conversation

crazo7924
Copy link
Contributor

@crazo7924 crazo7924 commented Dec 1, 2022 •
edited
Loading

Giving a warning sounds better in my opinion.

attempts to fix #14433

Summary of the Pull Request

References

PR Checklist

  • Closes Consider rewording the new confirmCloseAllTabs SUI setting #14433
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@crazo7924
reword en-US value for confirmCloseAllTabs
9e5a7c0 
Giving a warning sounds better in my opinion.

attempts to fix microsoft#14433
@ghost ghost added Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Dec 1, 2022
@carlos-zamora carlos-zamora requested a review from DHowett December 1, 2022 18:02
@crazo7924
Copy link
Contributor Author

any updates on this?

@DHowett
Copy link
Member

DHowett commented Dec 8, 2022

Sorry for the delay!

DHowett
DHowett reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think?

DHowett
DHowett approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 9, 2022
@ghost
Copy link

ghost commented Dec 9, 2022

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett DHowett merged commit 86aa666 into microsoft:main Dec 9, 2022
DHowett pushed a commit that referenced this pull request Dec 12, 2022
@crazo7924 @DHowett
reword en-US value for confirmCloseAllTabs (#14473)
bc860a9 
Fixes #14433

(cherry picked from commit 86aa666)
Service-Card-Id: 87207139
Service-Version: 1.16
@ghost
Copy link

ghost commented Dec 14, 2022

🎉Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees

@DHowett DHowett

Labels
Area-SettingsUI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. zBugBash-Consider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider rewording the new confirmCloseAllTabs SUI setting
3 participants
@crazo7924 @DHowett @zadjii-msft