Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find out how often are people actually using marks, Themes #14356

Merged
10 commits merged into from
Dec 1, 2022
Merged

Find out how often are people actually using marks, Themes #14356

10 commits merged into from
Dec 1, 2022

Conversation

zadjii-msft
Copy link
Member

Let's find out!

@DHowett
Copy link
Member

DHowett commented Nov 8, 2022

@lhecker can verify that we're tagging properly (usage vs performance, etc.)

@carlos-zamora
Copy link
Member

@PankajBhojwani You met with Michael a while back to chat about how we can do telemetry better (apparently we've been doing it wrong). This seems like a good opportunity to apply some of that 😉.

lhecker
lhecker approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think moving it into CascadiaSettingsSerialization.cpp would be better. That's where the AtlasEngine metrics are already at. Otherwise I'd move both metrics over into _TryLoadSettings if anything...

I'm certain that ProductAndServiceUsage is the correct choice here. My understanding is: Performance is only ever appropriate for irregular events, like crashes for instance.

src/cascadia/TerminalApp/AppLogic.cpp Outdated Show resolved Hide resolved
DHowett
DHowett requested changes Nov 8, 2022
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple overarching questions.

FYI: Anything we mark as Usage can be exported as an event stream for the user to look at. Every usage entry we create will need to be documented in another repository with a localizable string that explains what the user actually did. "Clicked save in the Terminal settings" "Dismissed the find dialog" etc.

src/cascadia/TerminalApp/AppLogic.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/AppLogic.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalCore/TerminalApi.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalCore/pch.h Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 8, 2022
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 9, 2022
@zadjii-msft zadjii-msft added the Gathering-Data We'd like to gather telemetry to influence our decision label Nov 9, 2022
DHowett
DHowett requested changes Nov 11, 2022
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts -- is this the right data to collect?

src/cascadia/TerminalCore/TerminalApi.cpp Show resolved Hide resolved
src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 11, 2022
@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Nov 19, 2022
@ghost
Copy link

ghost commented Nov 19, 2022

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@zadjii-msft zadjii-msft removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Nov 22, 2022
@zadjii-msft zadjii-msft assigned zadjii-msft and unassigned DHowett Nov 22, 2022
@github-actions

This comment has been minimized.

Sign in to view
@zadjii-msft zadjii-msft removed their assignment Nov 30, 2022
@zadjii-msft zadjii-msft requested a review from DHowett November 30, 2022 19:10
DHowett
DHowett approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k let's do it!

will this tell us whether the user has overwritten the system themes? is that a thing?

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 1, 2022
@ghost
Copy link

ghost commented Dec 1, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 52cc523 into main Dec 1, 2022
@ghost ghost deleted the dev/migrie/b/14324-my-1.16-research branch December 1, 2022 02:11
DHowett pushed a commit that referenced this pull request Dec 1, 2022
@zadjii-msft @DHowett
Find out how often are people actually using marks, Themes (#14356)
785704f 
Let's find out!

* [x] This is all the current bullets in #14324. I'm going to leave that open till we signoff on the release.

(cherry picked from commit 52cc523)
Service-Card-Id: 86660872
Service-Version: 1.16
@zadjii-msft zadjii-msft mentioned this pull request Dec 2, 2022
Closed
8 tasks
@ghost
Copy link

ghost commented Dec 14, 2022

🎉Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@DHowett DHowett DHowett approved these changes

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees

@DHowett DHowett

Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Gathering-Data We'd like to gather telemetry to influence our decision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zadjii-msft @DHowett @carlos-zamora @lhecker