Pipe DirectKey events into TerminalPage for Alt+Space #14221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request operates on the same theory as #14217, but at a lower level. Carlos and I discovered that TerminalPage *already* has an action-dispatching key preview handler, and that my implementation of IDirectKeyListener handles focus-tree bubbling mostly correctly. Because of that discovery, we could move the IDirectKeyListener into TerminalPage itself and not have to complicate the SUI or the Command Palette with the DirectKey interface. Validation: When bound to Alt+Space, the system menu works in the command palette, the settings UI, and in read-only panes. Fixes #11970 Closes #14217 Fixes MSFT-41390832
ghost
added
Area-Accessibility
lhecker
approved these changes
Oct 14, 2022
|
@msftbot merge this in 2 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
PankajBhojwani
approved these changes
Oct 14, 2022
ghost
merged commit
DHowett
added a commit
that referenced
this pull request
Oct 14, 2022
This pull request operates on the same theory as #14217, but at a lower level. Carlos and I discovered that TerminalPage *already* has an action-dispatching key preview handler, and that my implementation of `IDirectKeyListener` handles focus-tree bubbling mostly correctly. Because of that discovery, we learned we could move the `IDirectKeyListener` into TerminalPage itself and not have to complicate the SUI or the Command Palette with the DirectKey interface. Validation: When bound to Alt+Space, the system menu works in the command palette, the settings UI, and in read-only panes. Fixes #11970 Closes #14217 Fixes MSFT-41390832 (cherry picked from commit d319d47) Service-Card-Id: 86228469 Service-Version: 1.15
DHowett
added a commit
that referenced
this pull request
Oct 14, 2022
This pull request operates on the same theory as #14217, but at a lower level. Carlos and I discovered that TerminalPage *already* has an action-dispatching key preview handler, and that my implementation of `IDirectKeyListener` handles focus-tree bubbling mostly correctly. Because of that discovery, we learned we could move the `IDirectKeyListener` into TerminalPage itself and not have to complicate the SUI or the Command Palette with the DirectKey interface. Validation: When bound to Alt+Space, the system menu works in the command palette, the settings UI, and in read-only panes. Fixes #11970 Closes #14217 Fixes MSFT-41390832 (cherry picked from commit d319d47) Service-Card-Id: 86228470 Service-Version: 1.16
|
🎉 Handy links: |
This was referenced Oct 18, 2022
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request operates on the same theory as #14217, but at a lower
level. Carlos and I discovered that TerminalPage already has an
action-dispatching key preview handler, and that my implementation of
IDirectKeyListenerhandles focus-tree bubbling mostly correctly.Because of that discovery, we learned we could move the
IDirectKeyListenerinto TerminalPage itself and not have to complicatethe SUI or the Command Palette with the DirectKey interface.
Validation:
When bound to Alt+Space, the system menu works in the command palette,
the settings UI, and in read-only panes.
Fixes #11970
Closes #14217
Fixes MSFT-41390832