Fix a missing entry for intenseTextStyle in the Profile schema #14210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Schema
lhecker
approved these changes
Oct 13, 2022
|
(I changed the wording from Thanks for doing this! |
DHowett
approved these changes
Oct 14, 2022
DHowett
pushed a commit
that referenced
this pull request
Oct 14, 2022
Fix a missing entry in the JSON schema for `intenseTextStyle`. The JSON schema was missing an entry in the Profile section for `intenseTextStyle`. I have added it as it appears in AppearanceConfig. Note that this is currently duplicated in the schema -- however, this is the pattern used already in Profile as AppearanceConfig entries have alternate descriptions (and I have updated the description in that section to make it clear it applies to unfocused terminals). Longer-term, it likely makes sense to consolidate all entires into ApperanceConfig and rely on the description for the `unfocusedApperance` object/the name of the object to make the limited scope of those keys clear, so that Profile can simply extend ApperanceConfig and the duplication in the schema can be reduced. ## Validation Steps Performed Validation with schema verifying tools including VS Code. Partially addresses #13387 (cherry picked from commit 33cb0eb) Service-Card-Id: 86228742 Service-Version: 1.15
DHowett
pushed a commit
that referenced
this pull request
Oct 14, 2022
Fix a missing entry in the JSON schema for `intenseTextStyle`. The JSON schema was missing an entry in the Profile section for `intenseTextStyle`. I have added it as it appears in AppearanceConfig. Note that this is currently duplicated in the schema -- however, this is the pattern used already in Profile as AppearanceConfig entries have alternate descriptions (and I have updated the description in that section to make it clear it applies to unfocused terminals). Longer-term, it likely makes sense to consolidate all entires into ApperanceConfig and rely on the description for the `unfocusedApperance` object/the name of the object to make the limited scope of those keys clear, so that Profile can simply extend ApperanceConfig and the duplication in the schema can be reduced. ## Validation Steps Performed Validation with schema verifying tools including VS Code. Partially addresses #13387 (cherry picked from commit 33cb0eb) Service-Card-Id: 86228743 Service-Version: 1.16
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a missing entry in the JSON schema for
intenseTextStyle.The JSON schema was missing an entry in the Profile section for
intenseTextStyle. I have added it as it appears in AppearanceConfig.Note that this is currently duplicated in the schema -- however, this is
the pattern used already in Profile as AppearanceConfig entries have
alternate descriptions (and I have updated the description in that
section to make it clear it applies to unfocused terminals).
Longer-term, it likely makes sense to consolidate all entires into
ApperanceConfig and rely on the description for the
unfocusedApperanceobject/the name of the object to make the limited scope of those keys
clear, so that Profile can simply extend ApperanceConfig and the
duplication in the schema can be reduced.
Validation Steps Performed
Validation with schema verifying tools including VS Code.
Partially addresses #13387