Add a maximum OSC 8 URI length of 2MB following iTerm2 #14198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnachman/iTerm2@c0b2f48 Unlike iTerm2, we're not planning on making it configurable. This commit also adds a max length of 1024 characters on the "display URI" that we pass up to XAML, so as to not inundate the UI.
carlos-zamora
approved these changes
Oct 12, 2022
PankajBhojwani
approved these changes
Oct 12, 2022
|
@msftbot merge this in 1 minute |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
deleted the
dev/duhowett/why_do_you_build_me_up,_buttercup,_just_to_truncate_me
branch
DHowett
added a commit
that referenced
this pull request
Oct 13, 2022
gnachman/iTerm2@c0b2f48 Unlike iTerm2, we're not planning on making it configurable. This commit also adds a max length of 1024 characters on the "display URI" that we pass up to XAML, so as to not inundate the UI. Fixes #14200 (cherry picked from commit 07201d6) Service-Card-Id: 86182617 Service-Version: 1.15
DHowett
added a commit
that referenced
this pull request
Oct 13, 2022
gnachman/iTerm2@c0b2f48 Unlike iTerm2, we're not planning on making it configurable. This commit also adds a max length of 1024 characters on the "display URI" that we pass up to XAML, so as to not inundate the UI. Fixes #14200 (cherry picked from commit 07201d6) Service-Card-Id: 86182618 Service-Version: 1.16
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gnachman/iTerm2@c0b2f48
Unlike iTerm2, we're not planning on making it configurable.
This commit also adds a max length of 1024 characters on the "display URI" that we pass up to XAML, so as to not inundate the UI.
Fixes #14200