Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to XAML 2.7.3 #14123

Merged
1 commit merged into from
Oct 7, 2022
Merged

Update to XAML 2.7.3 #14123

1 commit merged into from
Oct 7, 2022

Conversation

AZero13
Copy link
Contributor

@AZero13 AZero13 commented Oct 3, 2022

And the prerelease version of it

Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there's any value in updating to 2.7.3, when we could also upgrade to 2.8. (I'm not a WinUI versioning expert though...)

@zadjii-msft
Copy link
Member

I'd rather we keep the scratch on the same version as the main solution (i.e., 2.7.3).

Was this tested locally? The scratch sln doesn't build in CI, so it'll need a manual validation

@AZero13
Copy link
Contributor Author

AZero13 commented Oct 5, 2022

This was indeed tested locally.

And the prerelease version of it
@DHowett
Copy link
Member

DHowett commented Oct 5, 2022

I'm not sure if there's any value in updating to 2.7.3, when we could also upgrade to 2.8. (I'm not a WinUI versioning expert though...)

2.8 is much riskier (new version and all!) and requires a WebView2 dependency...

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zadjii-msft yup, scratch builds and deploys just fine :)

For anybody that's interested, here's the XAML releases page

@carlos-zamora
Copy link
Member

@msftbot merge this in 10 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Oct 7, 2022
@ghost
Copy link

ghost commented Oct 7, 2022

Hello @carlos-zamora!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Fri, 07 Oct 2022 00:13:16 GMT, which is in 10 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 11ad047 into microsoft:main Oct 7, 2022
ghost pushed a commit that referenced this pull request Oct 7, 2022
This will let those projects build. I forgot to include them last time for some reason.

See PR #14123
DHowett pushed a commit that referenced this pull request Dec 12, 2022
And the prerelease version of it

(cherry picked from commit 11ad047)
Service-Card-Id: 87207161
Service-Version: 1.16
DHowett pushed a commit that referenced this pull request Dec 12, 2022
And the prerelease version of it

(cherry picked from commit 11ad047)
Service-Card-Id: 87207160
Service-Version: 1.15
@ghost
Copy link

ghost commented Dec 14, 2022

🎉Windows Terminal v1.15.3465.0 and v1.15.3466.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Dec 14, 2022

🎉Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0 has been released which incorporates this pull request.:tada:

Handy links:

@zadjii-msft
Copy link
Member

Hmm. This predates 1.15.2875.0, which was the first time that #14501 was reported, so this ain't it.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants