-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AtlasEngine: Block chars done right-er #14099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I once again cannot profess to understand the math changes without scrutinizing them, but I will "go with it"
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
The If some other code is difficult to understand let me know and I'll try to add some better comments! |
This commit makes the following improvements: * Only adjust block characters that come from fallback fonts. This ensures that the glyphs of the chosen font all look exactly as they were designed. * When adjusting the size, use the fallback font's full block glyph U+2588 to determine the size that the given glyph should have. Closes #14098 ## Validation Steps Performed * Print `UTF-8-demo.txt` in Consolas. * All block glyphs look uniform. ✅ (cherry picked from commit 97abc3d) Service-Card-Id: 86159056 Service-Version: 1.16
🎉 Handy links: |
This commit makes the following improvements:
that the glyphs of the chosen font all look exactly as they were designed.
to determine the size that the given glyph should have.
Closes #14098
Validation Steps Performed
UTF-8-demo.txt
in Consolas.