Reduce amount of telemetry events #13951
Conversation
lhecker
added
Product-Terminal
lhecker
force-pushed
the
dev/lhecker/telemetry
branch
from
3868bd0
to
ac18870
Compare
|
|
||
| GetSystemTimeAsFileTime(&now); | ||
|
|
||
| const auto latency = asSeconds(asInteger(now) - asInteger(creationTime)); |
There was a problem hiding this comment.
I don't understand; is it a guarantee that this thread is the right one?
There was a problem hiding this comment.
The Initialized callback is on the main thread right? I mean after all it calls all those _root, etc. functions... Then yeah it's the right one.
I chose GetThreadTimes instead of GetProcessTimes, because GetProcessTimes is pretty bad when it comes to performance (intentionally so). To improve runtime performance each thread records its own kernel/user-mode times (because then you don't need to acquire any shared/global locks). But if you call GetProcessTimes it has to acquire a shared/global lock to read and accumulate all those counters. GetThreadTimes doesn't have that issue and delivers the same result if called on the main thread.
lhecker
added
the
AutoMerge
|
Hello @lhecker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit This commit reduces the amount of telemetry during general usage by about half.
8 events that weren't really used anymore were removed.
1 new event was added ("AppInitialized") which will help us investigate #5907.
During review 9 events were found that were incorrectly tagged as perf. data.
* Launch Windows Terminal
* The "latency" field "AppInitialized" matches the approx. launch time ✅
(cherry picked from commit 37c159a)
Service-Card-Id: 85548958
Service-Version: 1.15
This commit reduces the amount of telemetry during general usage by about half.
8 events that weren't really used anymore were removed.
1 new event was added ("AppInitialized") which will help us investigate #5907.
During review 9 events were found that were incorrectly tagged as perf. data.
Validation Steps Performed