Disable RTTI on TerminalApp and friends #13947
Conversation
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 44 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Hopefully the tests are comprehensive enough to tell us whether this works for us. I suspect that CLI11 would know by now... |
When Leonard updated CLI11 in #12658, he imported a version that no longer requires RTTI. Since CLI11 was the only reason we had enabled RTTI in any of our projects, we're finally able to turn it off. | | TerminalApp.dll | MSIX Package | | ------ | ---------------:| ------------:| | Before | 3180KiB | 6545KiB | | After | 1970KiB | 6426KiB | | Delta | **-1210KiB** | **-119KiB** | (cherry picked from commit e682cda) Service-Card-Id: 85546966 Service-Version: 1.15
|
🎉 Handy links: |
|
🎉 Handy links: |
When Leonard updated CLI11 in #12658, he imported a version that no
longer requires RTTI. Since CLI11 was the only reason we had enabled
RTTI in any of our projects, we're finally able to turn it off.