Fix a race condition in UpdatePatternLocations #13859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
DHowett
approved these changes
Aug 29, 2022
|
@msftbot merge this in 5 minutes |
ghost
added
the
AutoMerge
|
Hello @carlos-zamora! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Sep 6, 2022
Since locking the console can take a non-trivial amount of time, the main thread might have already released the ControlCore instance, while the `UpdatePatternLocations` background thread is holding the last active reference. If the function call goes out of scope, we destroy the instance, which might not be safe, considering its members are usually only used by the main thread. This commit fixes the issue by only holding a reference of the `Terminal`. ## Validation Steps Performed * Patterns are recognized ✅ (cherry picked from commit 12122b2) Service-Card-Id: 85321064 Service-Version: 1.15
|
🎉 Handy links: |
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since locking the console can take a non-trivial amount of time,
the main thread might have already released the ControlCore instance, while the
UpdatePatternLocationsbackground thread is holding the last active reference.If the function call goes out of scope, we destroy the instance, which might
not be safe, considering its members are usually only used by the main thread.
This commit fixes the issue by only holding a reference of the
Terminal.Validation Steps Performed