Stop writing optional theme fields #13702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Theming
lhecker
commented
Aug 9, 2022
Comment on lines
+37
to
+38
| #define THEME_SETTINGS_TO_JSON(type, name, jsonKey, ...) \ | ||
| JsonUtils::SetValueForKey(json, jsonKey, _##name); |
There was a problem hiding this comment.
Primary fix. Fixes most fields from appearing (like useMica).
Comment on lines
-225
to
-228
| Theme::Theme() noexcept : | ||
| Theme{ winrt::WUX::ElementTheme::Default } | ||
| { | ||
| } |
There was a problem hiding this comment.
Secondary fix. Prevents window.applicationTheme from appearing.
Note how this calls the other constructor which sets the _Window field.
DHowett
approved these changes
Aug 9, 2022
zadjii-msft
approved these changes
Aug 10, 2022
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other settings model classes call
JsonUtils::SetValueForKeywith theprivate
_##valuemember as the value. Since_##valueis an optional,this prevented writing out unset, optional fields. The new
Themesclassdeviated from this and this commit brings it back in line with the others.
Closes #13544
Validation Steps Performed
{ "name": "test" }theme