Replace result codes with exceptions in JumpList #13688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-CodeHealth
lhecker
force-pushed
the
dev/lhecker/5907-jumplist
branch
from
7b46c7b to
f9dd951
Compare
lhecker
commented
Aug 5, 2022
Comment on lines
+117
to
+119
| // It's easier to clear the list and re-add everything. The settings aren't | ||
| // updated often, and there likely isn't a huge amount of items to add. | ||
| THROW_IF_FAILED(jumplistItems->Clear()); |
There was a problem hiding this comment.
This PR is much easier to review by suppressing whitespace changes. 🙂
DHowett
approved these changes
Aug 5, 2022
|
nit: reword PR name/commit to be in imperative style. Imagine that it'll complete the sentence, "This commit will..." :) |
lhecker
changed the title
zadjii-msft
approved these changes
Aug 8, 2022
lhecker
added
the
AutoMerge
|
Hello @lhecker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Aug 8, 2022
This commit simplifies `Jumplist::UpdateJumplist` by using exceptions instead of returning error codes. Otherwise the code is identical to before. (cherry picked from commit 768d4b5) Service-Card-Id: 84836267 Service-Version: 1.15
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplifies
Jumplist::UpdateJumplistby using exceptionsinstead of returning error codes. Otherwise the code is identical to before.