Make Mark Mode keybindings precede custom keybindings #13659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-TerminalControl
carlos-zamora
force-pushed
the
dev/cazamor/mark-mode/mamo-precedes-kbd
branch
from
83e41a9 to
a8cd0cf
Compare
|
Hmm... I'm marking this as a service-able bugfix. But if anybody disagrees, let me know. |
zadjii-msft
reviewed
Aug 2, 2022
carlos-zamora
force-pushed
the
dev/cazamor/mark-mode/mamo-precedes-kbd
branch
from
7f7de33 to
d980227
Compare
carlos-zamora
added a commit
that referenced
this pull request
Aug 2, 2022
lhecker
reviewed
Aug 3, 2022
carlos-zamora
added a commit
that referenced
this pull request
Aug 3, 2022
lhecker
approved these changes
Aug 5, 2022
6 tasks
zadjii-msft
approved these changes
Aug 18, 2022
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Sep 6, 2022
This PR moves the key handling for mark mode into a helper method that is then called before an action/key binding is attempted. Epic: #4993 Closes #13533 - Add custom keybinding to "down" arrow key - in mark mode --> selection updates appropriately - out of mark mode --> keybinding executed Amended by DHowett to remove URL targeting features. (cherry picked from commit 70313db) Service-Card-Id: 84711521 Service-Version: 1.15
|
🎉 Handy links: |
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR moves the key handling for mark mode into a helper method that is then called before an action/key binding is attempted.
References
Epic: #4993
Closes #13533
Validation Steps Performed