Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GdiEngine: Invalidate entire rows at a time #13638

Merged
1 commit merged into from
Aug 2, 2022
Merged

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Jul 31, 2022

This fixes an issue were overwriting parts of a row would only trigger
that specific portion of the row to be redrawn. This isn't just
problematic for combining characters, but also for things like
the new TestDbcsBisectWriteCells test introduced in #13626.

Benchmarks showed no impact on performance whatsoever.

Validation Steps Performed

@zadjii-msft zadjii-msft added this to the Terminal v1.16 milestone Aug 1, 2022
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's go for it. GDI doesn't have the bitmap for invalidation so we don't really need to worry about changing the invalid map to just a singular array of invalid rows (akin to dx). I'm cool with this.

@lhecker lhecker added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 2, 2022
@ghost
Copy link

ghost commented Aug 2, 2022

Hello @lhecker!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit d521202 into main Aug 2, 2022
@ghost ghost deleted the dev/lhecker/gdi-row-invalidation branch August 2, 2022 19:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants