Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename newTabPosition values #13602

Merged
2 commits merged into from
Jul 26, 2022
Merged

Rename newTabPosition values #13602

2 commits merged into from
Jul 26, 2022

Conversation

serd2011
Copy link
Contributor

@serd2011 serd2011 commented Jul 26, 2022 •
edited by DHowett
Loading

Renames newTabPosition strings and enums.
Also fixes the schema, noted in #13469 (comment)

Closes #13597

@ghost ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Jul 26, 2022
lhecker
lhecker approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a concern, but I'm gonna approve this ahead of time regardless...

src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h Show resolved Hide resolved
@DHowett
Copy link
Member

DHowett commented Jul 26, 2022

Thanks for jumping on this fix so quickly, @serd2011!

@DHowett DHowett changed the title Renames newTabPosition strings Rename newTabPosition values Jul 26, 2022
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 26, 2022
@ghost
Copy link

ghost commented Jul 26, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 4713764 into microsoft:main Jul 26, 2022
@ghost
Copy link

ghost commented Sep 13, 2022

🎉Windows Terminal Preview v1.16.252 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Sep 13, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename the newTabPosition strings
3 participants
@serd2011 @DHowett @lhecker