Wire up passing LNK/EXE data from OpenCon to ITerminalHandoff #13570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-DefApp
Area-Server
This comment has been minimized.
This comment has been minimized.
DHowett
reviewed
Jul 22, 2022
DHowett
reviewed
Jul 22, 2022
|
hey look, this made this better: |
helk yeah |
DHowett
requested changes
Aug 12, 2022
| <Import Project="..\..\..\packages\Microsoft.UI.Xaml.2.7.1\build\native\Microsoft.UI.Xaml.targets" Condition="Exists('..\..\..\packages\Microsoft.UI.Xaml.2.7.1\build\native\Microsoft.UI.Xaml.targets')" /> | ||
| <Import Project="..\..\..\packages\Microsoft.Toolkit.Win32.UI.XamlApplication.6.1.3\build\native\Microsoft.Toolkit.Win32.UI.XamlApplication.targets" Condition="Exists('..\..\..\packages\Microsoft.Toolkit.Win32.UI.XamlApplication.6.1.3\build\native\Microsoft.Toolkit.Win32.UI.XamlApplication.targets')" /> | ||
| <!-- This -must- go after cppwinrt.build.post.props because that includes many VS-provided props including appcontainer.common.props, which stomps on what cppwinrt.targets did. --> | ||
| <Import Project="$(OpenConsoleDir)src\common.nugetversions.targets" /> |
There was a problem hiding this comment.
this project becomes less sampley every day!
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
|
Yo @DHowett I did run this with appverifier and this ran clean 😄 |
ghost
requested review from
|
@msftbot make sure @DHowett-MSFT signs off |
ghost
added
the
AutoMerge
|
This will never be true. It will not clear this status, so you'll have to manually merge it. :) |
|
🎉 Handy links: |
ghost
mentioned this pull request
DHowett
pushed a commit
that referenced
this pull request
Oct 14, 2022
This PR by itself doesn't _really_ change much. Technically, now the Terminal will respect the Title of a `.lnk` when started for defterm, but we don't do anything else yet. Primarily, the goal of this PR is to just wire up startup info in OpenConsole to the connected Terminal. * This required a bit of changes in `srvinit.cpp:ConsoleEstablishHandoff` to replicate other bits of startup, where we crack open the connect message to get the relevant bits of info. * We pack that all into a `TERMINAL_STARTUP_INFO`, which we pass along to the registered terminal application. * `ConptyConnection` accepts the handoff, and gathers that information out of the `TERMINAL_STARTUP_INFO` * Some other updates to the scratch sln were made to make it build again (related, but unimportant). * This is a precursor to: * #13111 * #12154 * Closes #9458 * Tested manually * I work here (cherry picked from commit 7e47f6a) Service-Card-Id: 86230565 Service-Version: 1.15
DHowett
added a commit
that referenced
this pull request
Oct 14, 2022
DHowett
added a commit
that referenced
this pull request
Oct 14, 2022
ghost
pushed a commit
that referenced
this pull request
Oct 15, 2022
DHowett
added a commit
that referenced
this pull request
Oct 17, 2022
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR by itself doesn't really change much. Technically, now the Terminal will respect the Title of a
.lnkwhen started for defterm, but we don't do anything else yet. Primarily, the goal of this PR is to just wire up startup info in OpenConsole to the connected Terminal.srvinit.cpp:ConsoleEstablishHandoffto replicate other bits of startup, where we crack open the connect message to get the relevant bits of info.TERMINAL_STARTUP_INFO, which we pass along to the registered terminal application.ConptyConnectionaccepts the handoff, and gathers that information out of theTERMINAL_STARTUP_INFO