Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a crash when showTabsInTitlebar:false #13561

Merged
1 commit merged into from
Jul 22, 2022
Merged

Fix a crash when showTabsInTitlebar:false #13561

1 commit merged into from
Jul 22, 2022

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Jul 21, 2022 •
edited by DHowett
Loading

Does what it says on the tin.

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Severity-Crash Crashes are real bad news. Area-Theming Anything related to the theming of elements of the window labels Jul 21, 2022
DHowett
DHowett reviewed Jul 21, 2022
View reviewed changes
src/cascadia/WindowsTerminal/AppHost.cpp
nonClientWindow->SetTitlebarBackground(_logic.TitlebarBrush());
if (_useNonClientArea)
{
auto nonClientWindow{ static_cast<NonClientIslandWindow*>(_window.get()) };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now here's a silly question . . . would it be better to implement SetTitlebarBackground as a virtual on IslandWindow to enable future customizability? Or, would that cause us to erroneously change the titlebar background color when the user didn't want it to change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not titlebar.background for a reason 😉 I dunno if there's a way to set the titlebar part of the frame color separate from the rest of the borders in the frame, and it's not a can of worms I want to investigate RN.

@DHowett DHowett added the Needs-Second It's a PR that needs another sign-off label Jul 21, 2022
@ghost ghost requested review from PankajBhojwani, carlos-zamora and lhecker July 21, 2022 22:20
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 22, 2022
@ghost
Copy link

ghost commented Jul 22, 2022

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 5ea25f1 into main Jul 22, 2022
@ghost ghost deleted the dev/migrie/b/theme-tab-out-of-titlebar branch July 22, 2022 11:19
@ghost
Copy link

ghost commented Sep 13, 2022

🎉Windows Terminal Preview v1.16.252 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@DHowett DHowett DHowett approved these changes

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

Assignees
No one assigned
Labels
Area-Theming Anything related to the theming of elements of the window Area-UserInterface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zadjii-msft @DHowett @lhecker