Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send focus events even in ReadOnly mode #13483

Merged
3 commits merged into from
Jul 12, 2022
Merged

Send focus events even in ReadOnly mode #13483

3 commits merged into from
Jul 12, 2022

Conversation

zadjii-msft
Copy link
Member

Does what it says on the tin. When we get focused, temporarily turn off readonly mode, as to not pop the dialog when the focus sequence is eventually sent to the connection.

@ghost ghost added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Jul 11, 2022
@zadjii-msft zadjii-msft requested a review from lhecker July 12, 2022 12:02
@DHowett
Copy link
Member

DHowett commented Jul 12, 2022

Build go boom

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 12, 2022
@ghost
Copy link

ghost commented Jul 12, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit b4a52c8 into main Jul 12, 2022
@ghost ghost deleted the dev/migrie/b/13461-readonly-focus branch July 12, 2022 19:48
DHowett pushed a commit that referenced this pull request Jul 15, 2022
@zadjii-msft @DHowett
Send focus events even in ReadOnly mode (#13483)
1a56bc5 
Does what it says on the tin. When we get focused, temporarily turn off readonly mode, as to not pop the dialog when the focus sequence is eventually sent to the connection.

* closes #13461

(cherry picked from commit b4a52c8)
Service-Card-Id: 84111370
Service-Version: 1.14
DHowett pushed a commit that referenced this pull request Jul 19, 2022
@zadjii-msft @DHowett
Send focus events even in ReadOnly mode (#13483)
a4a12ef 
Does what it says on the tin. When we get focused, temporarily turn off readonly mode, as to not pop the dialog when the focus sequence is eventually sent to the connection.

* closes #13461

(cherry picked from commit b4a52c8)
Service-Card-Id: 84111371
Service-Version: 1.15
@zadjii-msft zadjii-msft mentioned this pull request Aug 2, 2022
Closed
@ghost
Copy link

ghost commented Aug 5, 2022

🎉Windows Terminal v1.14.196 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 5, 2022

🎉Windows Terminal Preview v1.15.200 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PankajBhojwani PankajBhojwani PankajBhojwani approved these changes

@DHowett DHowett DHowett approved these changes

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Terminal Preview - Read-only pane pop-up on tab switch
4 participants
@zadjii-msft @DHowett @lhecker @PankajBhojwani