Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also hide the scroll marks when hiding the scrollbar #13454

Merged
1 commit merged into from
Jul 7, 2022
Merged

Also hide the scroll marks when hiding the scrollbar #13454

1 commit merged into from
Jul 7, 2022

Conversation

zadjii-msft
Copy link
Member

This one's pretty obvious. I added another scrollbar sized grid to the terminal,
but I forgot to collapse it when the user requests "scrollbarState": "hidden".

@zadjii-msft
Also hide the scroll marks when hiding the scrollbar
f989319 
This one's pretty obvious. I added another scrollbar sized grid to the terminal,
but I forgot to collapse it when the user requests `"scrollbarState": "hidden"`.

* [x] Closes #13446
* [x] I work here
@ghost ghost added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Jul 7, 2022
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 7, 2022
@ghost
Copy link

ghost commented Jul 7, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 47 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented Jul 7, 2022

@msftbot merge this in 1 minutes

@ghost
Copy link

ghost commented Jul 7, 2022

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 07 Jul 2022 16:24:03 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit aa4e9f5 into main Jul 7, 2022
@ghost ghost deleted the dev/migrie/b/13446-clearly-no-one-on-the-dev-team-uses-this-one branch July 7, 2022 17:30
DHowett pushed a commit that referenced this pull request Jul 19, 2022
@zadjii-msft @DHowett
Also hide the scroll marks when hiding the scrollbar (#13454)
ba8171e 
This one's pretty obvious. I added another scrollbar sized grid to the terminal,
but I forgot to collapse it when the user requests `"scrollbarState": "hidden"`.

* [x] Closes #13446
* [x] I work here

(cherry picked from commit aa4e9f5)
Service-Card-Id: 83969639
Service-Version: 1.15
@ghost
Copy link

ghost commented Aug 5, 2022

🎉Windows Terminal Preview v1.15.200 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 5, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrollbar area is not hidden
3 participants
@zadjii-msft @DHowett @carlos-zamora