Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RelEng: Teach ServicingPipeline to infer the version if it's null #13439

Merged
merged 1 commit into from
Jul 6, 2022
Merged

RelEng: Teach ServicingPipeline to infer the version if it's null #13439

merged 1 commit into from
Jul 6, 2022

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Jul 5, 2022 

% .\tools\ReleaseEngineering\ServicingPipeline.ps1
Inferred servicing version 1.14
PICK f025c53dbab37a5a55ac23a51aba03e36467315f: Remove the fallback to wsl.exe when HKCU\...\Lxss doesn't exist (#13436)
 OK

lhecker
lhecker approved these changes Jul 5, 2022
View reviewed changes
tools/ReleaseEngineering/ServicingPipeline.ps1
@@ -61,6 +61,17 @@ Function Reject() {
$Host.ExitNestedPrompt()
}

If ([String]::IsNullOrEmpty($Version)) {
Copy link
Member

@lhecker lhecker Jul 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just write if (!$Version).
(I believe small if is the canonical variant nowadays.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Didn't know that. Is that supported on PS 5.1?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work. Is PS 5.1 still relevant though? We already require pwsh 7 or newer for the build anyways (to compress JSON strings).

tools/ReleaseEngineering/ServicingPipeline.ps1 Show resolved Hide resolved
@zadjii-msft zadjii-msft merged commit 16028de into main Jul 6, 2022
@zadjii-msft zadjii-msft deleted the dev/duhowett/infer branch July 6, 2022 11:11
DHowett added a commit that referenced this pull request Sep 6, 2022
@DHowett
RelEng: Teach ServicingPipeline to infer the version if it's null (#1…
062e2b3 
…3439)

```
% .\tools\ReleaseEngineering\ServicingPipeline.ps1
Inferred servicing version 1.14
PICK f025c53: Remove the fallback to wsl.exe when HKCU\...\Lxss doesn't exist (#13436)
 OK
```

(cherry picked from commit 16028de)
Service-Card-Id: 85487931
Service-Version: 1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DHowett @lhecker @zadjii-msft