Fix a race condition in CTerminalHandoff::s_StopListening #13410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
commented
Jul 1, 2022
| s_StopListening(); | ||
|
|
||
| std::unique_lock lock{ _mtx }; | ||
| LOG_IF_FAILED(s_StopListeningLocked()); |
There was a problem hiding this comment.
FYI this change is correct (i.e. holding the lock while calling s_StopListening).
Previously, s_StopListening would acquire the lock itself, so nothing has effectively changed here.
zadjii-msft
approved these changes
Jul 5, 2022
DHowett
approved these changes
Jul 5, 2022
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Jul 5, 2022
This commit fixes a minor race condition covered as part of #13368. The member `_pfnHandoff` was read without the mutex `_mtx` being locked first. The issue was solved by acquiring the lock early and running the entire `s_StopListening` function with that lock held. (cherry picked from commit 95a1962) Service-Card-Id: 83893125 Service-Version: 1.14
DHowett
pushed a commit
that referenced
this pull request
Jul 5, 2022
This commit fixes a minor race condition covered as part of #13368. The member `_pfnHandoff` was read without the mutex `_mtx` being locked first. The issue was solved by acquiring the lock early and running the entire `s_StopListening` function with that lock held. (cherry picked from commit 95a1962) Service-Card-Id: 83893126 Service-Version: 1.15
|
🎉 Handy links: |
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a minor race condition covered as part of #13368.
The member
_pfnHandoffwas read without the mutex_mtxbeing locked first.The issue was solved by acquiring the lock early and running the entire
s_StopListeningfunction with that lock held.