Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MVVM for the Rendering page #13391

Merged
5 commits merged into from
Jul 8, 2022
Merged

Implement MVVM for the Rendering page #13391

5 commits merged into from
Jul 8, 2022

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Jun 27, 2022 •
edited
Loading

Summary of the Pull Request

Implements a RenderingViewModel for the Rendering page in the SUI

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Rendering page still works

carlos-zamora
carlos-zamora reviewed Jun 27, 2022
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clean up the PR description too? Some of the checkbox items are unnecessary so you should be able to delete them from the description.

src/cascadia/TerminalSettingsEditor/RenderingViewModel.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalSettingsEditor/RenderingViewModel.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalSettingsEditor/RenderingViewModel.h Outdated Show resolved Hide resolved
src/cascadia/TerminalSettingsEditor/RenderingViewModel.h Outdated Show resolved Hide resolved
carlos-zamora
carlos-zamora requested changes Jun 27, 2022
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until 1.15 forks

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 27, 2022
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Area-SettingsUI Anything specific to the SUI labels Jul 5, 2022
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 8, 2022
@ghost
Copy link

ghost commented Jul 8, 2022

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit bbc570d into main Jul 8, 2022
@ghost ghost deleted the dev/pabhoj/mvvm_rendering branch July 8, 2022 22:50
@ghost
Copy link

ghost commented Sep 13, 2022

🎉Windows Terminal Preview v1.16.252 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett left review comments

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@lhecker lhecker lhecker approved these changes

Assignees
No one assigned
Labels
Area-SettingsUI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PankajBhojwani @DHowett @lhecker @carlos-zamora @zadjii-msft