-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce switchSelectionEndpoint
action
#13370
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
04a6d0b
to
2e48423
Compare
@msftbot merge this in 18 hours |
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Suggestion for me:
|
2e48423
to
02d6a07
Compare
02d6a07
to
5e49772
Compare
@msftbot merge this in 4 minutes |
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
🎉 Handy links: |
Chocolatey is still on 1.14.2281.0 for Windows Terminal so waiting for 1.15.x to come down the pipe. |
Summary of the Pull Request
Introduces the
switchSelectionEndpoint
action which switches whichever selection endpoint is targeted when a selection is present. For example, if you are targeting "start",switchSelectionEndpoint
makes it so that now you are targeting "end". This also updates the selection markers appropriately.References
Spec - #5804
#13358
Closes #3663
Detailed Description of the Pull Request / Additional comments
Most of the code is just standard code of adding a new action. Other than that, we have...
copy()
)UpdateSelection()
respect this swap.