Dismiss Terminal-by-default banner on handoff #13344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-DefApp
Issue-Bug
|
Does this work if the first tab in a session is a handoff? |
Yep! That's what I meant to say with the last bullet point in my validation steps. |
zadjii-msft
approved these changes
Jun 21, 2022
lhecker
added
the
AutoMerge
|
Hello @lhecker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Jun 30, 2022
It's not useful to notify users that WT can be made the default if it's already clearly being used for handoff. This commit will suppresses the banner then. ## PR Checklist * [x] Closes #13314 * [x] I work here ## Validation Steps Performed * Modify `TerminalPage::ShowSetAsDefaultInfoBar` to not check for `CascadiaSettings::IsDefaultTerminalSet()` * Set Terminal Dev as the default * Set incoming connections to open in the latest Terminal window * Delete `state.json` after every test below * Launching Terminal Dev shows the banner ✅ Launching `cmd.exe` dismisses the banner in the current Terminal ✅ * Launching `cmd.exe` launches Terminal Dev without banner ✅ (cherry picked from commit 24a53d4) Service-Card-Id: 83434412 Service-Version: 1.14
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not useful to notify users that WT can be made the default if it's already
clearly being used for handoff. This commit will suppresses the banner then.
PR Checklist
Validation Steps Performed
TerminalPage::ShowSetAsDefaultInfoBarto not check forCascadiaSettings::IsDefaultTerminalSet()state.jsonafter every test belowLaunching
cmd.exedismisses the banner in the current Terminal ✅cmd.exelaunches Terminal Dev without banner ✅