Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "JSON" to the "Open settings file" command names #13265

Merged
1 commit merged into from
Jun 10, 2022
Merged

Add "JSON" to the "Open settings file" command names #13265

1 commit merged into from
Jun 10, 2022

Conversation

zadjii-msft
Copy link
Member

@ghost ghost added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jun 10, 2022
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Jun 10, 2022
@ghost ghost requested review from PankajBhojwani, DHowett and lhecker June 10, 2022 15:44
@DHowett
Copy link
Member

DHowett commented Jun 10, 2022

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jun 10, 2022
@ghost
Copy link

ghost commented Jun 10, 2022

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Fri, 10 Jun 2022 16:40:30 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit dc8183a into main Jun 10, 2022
@ghost ghost deleted the dev/migrie/b/13225-json-file branch June 10, 2022 16:41
DHowett pushed a commit that referenced this pull request Jun 30, 2022
@zadjii-msft @DHowett
Add "JSON" to the "Open settings file" command names (#13265)
ddf46f2 
![image](https://user-images.githubusercontent.com/18356694/173090336-3512ee36-ae8b-41d5-8823-09cb1354c7ef.png)

* [x] Closes #13225

(cherry picked from commit dc8183a)
Service-Card-Id: 83524146
Service-Version: 1.14
@ghost
Copy link

ghost commented Jul 6, 2022

🎉Windows Terminal v1.14.186 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jul 6, 2022
Closed
@ghost
Copy link

ghost commented Jul 6, 2022

🎉Windows Terminal Preview v1.15.186 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@lhecker lhecker lhecker approved these changes

@DHowett DHowett DHowett approved these changes

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Open JSON file easier to discover
4 participants
@zadjii-msft @DHowett @lhecker @carlos-zamora