Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't attempt to split settings tabs #13172

Merged
1 commit merged into from
May 25, 2022
Merged

Don't attempt to split settings tabs #13172

1 commit merged into from
May 25, 2022

Conversation

ianjoneill
Copy link
Contributor

@ianjoneill ianjoneill commented May 25, 2022 •
edited by DHowett
Loading

Prevents a null pointer dereference when attempting to split a settings tab, due to it not being a terminal tab.

Validation Steps Performed

Manually tested.

@ghost ghost added the Issue-Bug It either shouldn't be doing this or needs an investigation. label May 25, 2022
@ianjoneill
Copy link
Contributor Author

FYI the crash occurs on 1.13 too - i.e. it isn't specific to 1.14.

zadjii-msft
zadjii-msft approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning up my mess 🙃

DHowett
DHowett approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, that is very subtle. "GetFocusedTabImpl" doesn't sound TerminalTab-specific.

We probably need to clean up how tabs work eventually.

@DHowett
Copy link
Member

DHowett commented May 25, 2022

Thanks for jumping on the fix @ianjoneill!

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 25, 2022
@ghost
Copy link

ghost commented May 25, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 6439b4d into microsoft:main May 25, 2022
DHowett pushed a commit that referenced this pull request May 25, 2022
@ianjoneill @DHowett
Don't attempt to split settings tabs (#13172)
287db8a 
Prevents a null pointer dereference when attempting to split a settings tab, due to it not being a terminal tab.

* [x] Closes #13166

## Validation Steps Performed
Manually tested.

(cherry picked from commit 6439b4d)
Service-Card-Id: 82395540
Service-Version: 1.14
@ghost
Copy link

ghost commented Jun 10, 2022

🎉Windows Terminal Preview v1.14.145 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jun 10, 2022
Closed
@ianjoneill ianjoneill mentioned this pull request Jul 18, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

press atl + shift + D on setting page, then wt will crash
3 participants
@ianjoneill @DHowett @zadjii-msft