Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimental.useBackgroundImageForWindow to schema #13114

Merged
merged 1 commit into from
May 17, 2022
Merged

Add experimental.useBackgroundImageForWindow to schema #13114

merged 1 commit into from
May 17, 2022

Conversation

carlos-zamora
Copy link
Member

Adds the experimental.useBackgroundImageForWindow global setting introduced in #12893 to the schema.

@zadjii-msft zadjii-msft added this to the Terminal v1.14 milestone May 16, 2022
@carlos-zamora carlos-zamora added AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off labels May 16, 2022
@ghost
Copy link

ghost commented May 16, 2022

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 3 hours 33 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost requested review from zadjii-msft, PankajBhojwani and DHowett May 16, 2022 23:03
@DHowett DHowett merged commit b699f92 into main May 17, 2022
@DHowett DHowett deleted the dev/cazamor/schema/useBackgroundImageForWindow branch May 17, 2022 00:06
@DHowett DHowett restored the dev/cazamor/schema/useBackgroundImageForWindow branch May 17, 2022 00:06
@DHowett DHowett deleted the dev/cazamor/schema/useBackgroundImageForWindow branch May 17, 2022 00:06
@DHowett DHowett restored the dev/cazamor/schema/useBackgroundImageForWindow branch May 17, 2022 00:06
carlos-zamora added a commit that referenced this pull request May 17, 2022
@carlos-zamora
Add experimental.useBackgroundImageForWindow to schema (#13114)
5fbd539 
Adds the `experimental.useBackgroundImageForWindow` global setting introduced in #12893 to the schema.

(cherry picked from commit b699f92)
Service-Card-Id: 82002294
Service-Version: 1.14
@ghost
Copy link

ghost commented May 24, 2022

🎉Windows Terminal Preview v1.14.143 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off
Projects
None yet
Milestone
Terminal v1.14
Development

Successfully merging this pull request may close these issues.
4 participants
@carlos-zamora @DHowett @lhecker @zadjii-msft