[High Contrast] Fix red SUI background #13083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Accessibility
carlos-zamora
added
zPreview-Service-Queued-1.13
DHowett
approved these changes
May 11, 2022
|
@carlos-zamora FYI Mike is comfortable with us porting the new Win11 UI changes in the SUI and the Search/Command Palette if the HC things are fixed. Are you also comfortable with that? |
|
Pulled from body: |
ghost
added
Area-Accessibility
|
|
@msftbot merge this in 2 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
requested review from
PankajBhojwani
approved these changes
May 11, 2022
carlos-zamora
added a commit
that referenced
this pull request
May 12, 2022
Fixes the SUI background being red in high contrast mode. The issue was that `SolidBackgroundFillColorTertiary` purposefully has a bad High Contrast color[^1]. The fix was to be explicit in the theme resources so that `SolidBackgroundFillColorTertiary` is used in light and dark mode, but the standard high contrast one is used in high contrast mode. Since the page is the top-level XAML element in the Editor project, I had to introduce this in the App.xaml resources so that the page can find the theme resource. Closes #13065 Closes #13070 [^1]: https://github.com/microsoft/microsoft-ui-xaml/blob/40df43a61c013a6763f47dd7d89ed54f35999340/dev/CommonStyles/Common_themeresources_any.xaml#L650-L651 (cherry picked from commit a657cb0) Service-Card-Id: 81805351 Service-Version: 1.13
zadjii-msft
added a commit
that referenced
this pull request
May 23, 2022
ThemeResources are a persistent pain. Regressed in #13083. See also #12775 et. al. We can't just put those here though as StaticResources, because XAML will evaluate their values when the App is first loaded, and we'll always use the value from the OS theme, regarless of the requested theme. Kinda the same thing we've had to do with TabViewBackground in the past. * [x] Fixes something we noticed right before shipping
1 task
ghost
pushed a commit
that referenced
this pull request
May 23, 2022
ThemeResources are a persistent pain. Regressed in #13083. See also #12775 et. al. We can't just put those here though as StaticResources, because XAML will evaluate their values when the App is first loaded, and we'll always use the value from the OS theme, regarless of the requested theme. Kinda the same thing we've had to do with TabViewBackground in the past. * [x] Fixes something we noticed right before shipping
DHowett
pushed a commit
that referenced
this pull request
May 23, 2022
ThemeResources are a persistent pain. Regressed in #13083. See also #12775 et. al. We can't just put those here though as StaticResources, because XAML will evaluate their values when the App is first loaded, and we'll always use the value from the OS theme, regarless of the requested theme. Kinda the same thing we've had to do with TabViewBackground in the past. * [x] Fixes something we noticed right before shipping (cherry picked from commit bb03b00) Service-Card-Id: 82303612 Service-Version: 1.14
DHowett
pushed a commit
that referenced
this pull request
May 23, 2022
ThemeResources are a persistent pain. Regressed in #13083. See also #12775 et. al. We can't just put those here though as StaticResources, because XAML will evaluate their values when the App is first loaded, and we'll always use the value from the OS theme, regarless of the requested theme. Kinda the same thing we've had to do with TabViewBackground in the past. * [x] Fixes something we noticed right before shipping (cherry picked from commit bb03b00) Service-Card-Id: 82303611 Service-Version: 1.13
|
🎉 Handy links: |
This was referenced May 24, 2022
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the SUI background being red in high contrast mode. The issue was
that
SolidBackgroundFillColorTertiarypurposefully has a bad HighContrast color1.
The fix was to be explicit in the theme resources so that
SolidBackgroundFillColorTertiaryis used in light and dark mode, butthe standard high contrast one is used in high contrast mode. Since the
page is the top-level XAML element in the Editor project, I had to
introduce this in the App.xaml resources so that the page can find the
theme resource.
Closes #13065
Closes #13070
Footnotes
https://github.com/microsoft/microsoft-ui-xaml/blob/40df43a61c013a6763f47dd7d89ed54f35999340/dev/CommonStyles/Common_themeresources_any.xaml#L650-L651 ↩