Multi-Click Selection: Triple-Click Settings + Viewport Selection

[carlos-zamora]

Summary of the Pull Request

Introduces "viewport selection" which creates a selection of the entire viewport. Also, adds per-profile settings to decide whether a triple-click performs a line selection or viewport selection (disabling it is also an option).

References

Builds on #1197. Similar to #1273.
Closes #1084.

PR Checklist

• Closes Feature Request: Take screenshot of selection/viewport #1084
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Requires documentation to be updated
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.

Detailed Description of the Pull Request / Additional comments

• TerminalSettings:
  • add property to winrt TerminalSettings
• Terminal App:
  • read/write JSON for this new property
  • default set to line selection
• TerminalCore:
  • import/use selection mode from ICoreSettings
  • perform proper action
• UnitTests_TerminalCore:
  • Added setting to MockTermSettings

Validation Steps Performed

• modified profiles.json. Then performed triple click in an instance of that profile

[zadjii-msft]

mild concern that "Selection Mode" might be too broad a name here - though I don't have a good example of why we wouldn't want to call it that.

[carlos-zamora]

Renamed to TripleClickSelectionMode. I feel like we don't wanna attach this functionality just to TripleClick though. So I'm open to suggestions :)

[miniksa]

I mean I'm not totally convinced that triple click needs a settable behavior. The linked thread isn't super relevant to making this a preference that customers are actually looking for.

I also don't know why you just didn't go for broke at this point and put viewport on quadruple click and the entire buffer on quintuple click and the entire known universe of data on sextuple click or something.

[carlos-zamora]

I mean I'm not totally convinced that triple click needs a settable behavior. The linked thread isn't super relevant to making this a preference that customers are actually looking for.

Honestly, it'd probably just be better to have this functionality come in after we do pointer bindings (#1553 ). Then you could just set the behavior you want on a triple click. Should we just back this out then?

I also don't know why you just didn't go for broke at this point and put viewport on quadruple click and the entire buffer on quintuple click and the entire known universe of data on sextuple click or something.

We can doesn't mean we should. I don't think I've ever actually seen anything have 4+ click functionality.

[carlos-zamora]

Abandoning this PR so that it can be done right/better with pointer bindings.