Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent the virtual viewport bottom being updated incorrectly #12972

Merged
9 commits merged into from
May 2, 2022
Merged

Prevent the virtual viewport bottom being updated incorrectly #12972

9 commits merged into from
May 2, 2022

Commits on Apr 26, 2022

  1. Reimplement virtual bottom adjustment in _InternalSetViewportSize.

    @j4james
    j4james committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    3b2f4dd View commit details
    Browse the repository at this point in the history

  2. Make sure VT resize operations keep the cursor in view.

    @j4james
    j4james committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    d0d9e48 View commit details
    Browse the repository at this point in the history

  3. Only move the virtual bottom downwards in SetViewportOrigin.

    @j4james
    j4james committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    325b464 View commit details
    Browse the repository at this point in the history

  4. Always use the virtual viewport for SetConsoleCursorPosition viewport… 

    … snapping.
    @j4james
    j4james committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    60e88c1 View commit details
    Browse the repository at this point in the history

  5. Don't ever update the virtual bottom from MakeCursorVisible.

    @j4james
    j4james committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    8225119 View commit details
    Browse the repository at this point in the history

  6. Make sure ResizeWithReflow doesn't truncate the virtual buffer.

    @j4james
    j4james committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    47d6263 View commit details
    Browse the repository at this point in the history

  7. Don't update the virtual bottom from SelectAll.

    @j4james
    j4james committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    a468803 View commit details
    Browse the repository at this point in the history

  8. Initialize virtual bottom in ScreenBufferTests.

    @j4james
    j4james committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    6505dc6 View commit details
    Browse the repository at this point in the history

  9. Add some screen buffer tests.

    @j4james
    j4james committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    b0d609b View commit details
    Browse the repository at this point in the history