Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mp:PhoneIdentity to stop Store from rewriting our packages #12779

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Add mp:PhoneIdentity to stop Store from rewriting our packages #12779

merged 1 commit into from
Mar 28, 2022

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Mar 28, 2022

If we do not include mp:PhoneIdentity in our AppxManifest, the store
will edit our package and re-sign it for distribution. When that
happens, it creates a divergence: there are now two versions of our
package with the same name and version number, but different contents.

This breaks everything.

@DHowett
Add mp:PhoneIdentity to stop Store from rewriting our packages
b7d60db 
If we do not include mp:PhoneIdentity in our AppxManifest, the store
will edit our package and re-sign it for distribution. When that
happens, it creates a divergence: there are now two versions of our
package with the same name and version number, but different contents.

This breaks everything.
@DHowett
Copy link
Member Author

DHowett commented Mar 28, 2022

I'm running a test build at https://microsoft.visualstudio.com/Dart/_build/results?buildId=47119702&view=results, which I will upload to the store and re-download to verify.

@zadjii-msft
Copy link
Member

LOAD BEARING

@DHowett
Copy link
Member Author

DHowett commented Mar 28, 2022

Confirming. The store still edits our package, and re-signs it, but Add-AppxPackage successfully moves between identical versions.

Broken (1.12)

% add-appxpackage .\PreUpload\Microsoft.WindowsTerminal_Win11_1.12.10733.0_8wekyb3d8bbwe.msixbundle -ForceUpdateFromAnyVersion
% add-appxpackage .\Microsoft.WindowsTerminal_Win11_1.12.10733.0_8wekyb3d8bbwe.msixbundle -ForceUpdateFromAnyVersion

Add-AppxPackage: Deployment failed with HRESULT: 0x80073CFB, The provided package is already installed, and reinstallation of the package was blocked. Check the AppXDeployment-Server event log for details.
Deployment of package Microsoft.WindowsTerminal_1.12.10733.0_x64__8wekyb3d8bbwe was blocked because the provided package has the same identity as an already-installed package but the contents are different. Increment the version number of the package to be installed, or remove the old package for every user on the system before installing this package.
NOTE: For additional information, look for [ActivityId] 56386121-42b9-0000-860e-c758b942d801 in the Event Log or use the command line Get-AppPackageLog -ActivityID 56386121-42b9-0000-860e-c758b942d801

Working (1.14)

% add-appxpackage .\Microsoft.WindowsTerminal_Win11_1.14.877.0_8wekyb3d8bbwe.PreUpload.msixbundle
% add-appxpackage -ForceUpdateFromAnyVersion .\d9768881965a4c37a21b152f7dd3b041.msixbundle
% add-appxpackage .\Microsoft.WindowsTerminal_Win11_1.14.877.0_8wekyb3d8bbwe.PreUpload.msixbundle -ForceUpdateFromAnyVersion

@DHowett DHowett merged commit 0bc66ab into main Mar 28, 2022
@DHowett DHowett deleted the dev/duhowett/fix-the-dumb-manifest-problem branch March 28, 2022 22:28
DHowett added a commit that referenced this pull request Mar 28, 2022
@DHowett
Add mp:PhoneIdentity to stop Store from rewriting our packages (#12779)
f868564 
If we do not include mp:PhoneIdentity in our AppxManifest, the store
will edit our package and re-sign it for distribution. When that
happens, it creates a divergence: there are now two versions of our
package with the same name and version number, but different contents.

This breaks everything.

**THIS IS LOAD BEARING**

(cherry picked from commit 0bc66ab)
DHowett added a commit that referenced this pull request Mar 28, 2022
@DHowett
Add mp:PhoneIdentity to stop Store from rewriting our packages (#12779)
ad94616 
If we do not include mp:PhoneIdentity in our AppxManifest, the store
will edit our package and re-sign it for distribution. When that
happens, it creates a divergence: there are now two versions of our
package with the same name and version number, but different contents.

This breaks everything.

**THIS IS LOAD BEARING**

(cherry picked from commit 0bc66ab)
@zadjii-msft zadjii-msft mentioned this pull request Apr 4, 2022
Closed
@DHowett DHowett added zAskModeBug Priority-1 A description (P1) Issue-Bug It either shouldn't be doing this or needs an investigation. labels Apr 12, 2022
@ghost
Copy link

ghost commented Apr 19, 2022

🎉Windows Terminal v1.12.1098 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 19, 2022

🎉Windows Terminal Preview v1.13.1098 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa miniksa approved these changes

Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) zAskModeBug
Projects
Windows Terminal Ask Mode Submissions
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DHowett @zadjii-msft @miniksa