AtlasEngine: Fix grayscale blending shader #12734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DxEngine left - AtlasEngine right aliased: grayscale: cleartype: (ClearType is hard to see for colored text. You can see it on the white-on-black text.) |
lhecker
commented
Mar 21, 2022
Comment on lines
+150
to
+151
| float4 alphaCorrected = DWrite_ApplyAlphaCorrection(contrasted, intensity, gammaRatios); | ||
| color = alphaBlendPremultiplied(color, alphaCorrected * fg); |
There was a problem hiding this comment.
Here's a direct link showing the old code using alphaBlendPremultiplied here: 5964060#diff-ca02942b22b9baa16bcef607b524e1e4590793109f302c097b6705f0d1383310L135
DHowett
approved these changes
Mar 21, 2022
zadjii-msft
approved these changes
Mar 22, 2022
lhecker
added
Issue-Bug
|
Hello @lhecker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5964060 contains a regression were the grayscale blending algorithm used the
gamma corrected foreground color as the pixel color, instead of blending that
color with the background color first. Due to that the background color
got lost / got set to black. This breaks any dark-on-bright outputs.
PR Checklist
Validation Steps Performed
All 3 "antialiasing" settings work just like in DxEngine. ✅