Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round our Maximize button to match ControlsV2 styles #12660

Merged
1 commit merged into from
Mar 10, 2022
Merged

Round our Maximize button to match ControlsV2 styles #12660

1 commit merged into from
Mar 10, 2022

Conversation

zadjii-msft
Copy link
Member

Just look at the screenshot. Above is before, below is now.
image

These paths were taken straight from WinUI versions of these icons, thanks @pratikone for the alley oop.

@zadjii-msft
Round our Maximize button to match ControlsV2 styles
925eec8 
Just look at the screenshot. Above is before, below is now.

These paths were taken straight from WinUI versions of these icons

* [x] Closes #12433
* [x] Tested manually by _lookin at it_
@ghost ghost added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Mar 10, 2022
@zadjii-msft zadjii-msft added the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Mar 10, 2022
@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Mar 10, 2022
@ghost ghost requested review from miniksa, carlos-zamora and lhecker March 10, 2022 23:00
@zadjii-msft
Copy link
Member Author

@msftbot merge this in 1 minute

@ghost ghost requested a review from PankajBhojwani March 10, 2022 23:00
@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 10, 2022
@ghost
Copy link

ghost commented Mar 10, 2022

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 10 Mar 2022 23:01:53 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

miniksa
miniksa approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO ROUND.

@ghost ghost merged commit b55f3ab into main Mar 10, 2022
@ghost ghost deleted the dev/migrie/b/12433-rounder-ROUNDER branch March 10, 2022 23:16
zadjii-msft added a commit that referenced this pull request Mar 15, 2022
@zadjii-msft
Round our Maximize button to match ControlsV2 styles (#12660)
e995536 
Just look at the screenshot. Above is before, below is now.
![image](https://user-images.githubusercontent.com/18356694/157717931-f3e3167e-0234-425a-a8eb-02303f386dc6.png)

These paths were taken straight from WinUI versions of these icons, thanks @pratikone for the alley oop.

* [x] Closes #12433
* [x] Tested manually by _lookin at it_
@zadjii-msft zadjii-msft mentioned this pull request Mar 15, 2022
Merged
@DHowett
Copy link
Member

DHowett commented Mar 28, 2022

Somehow, I missed backporting this to 1.13 :p

DHowett pushed a commit that referenced this pull request Mar 28, 2022
@zadjii-msft @DHowett
Round our Maximize button to match ControlsV2 styles (#12660)
6986937 
Just look at the screenshot. Above is before, below is now.
![image](https://user-images.githubusercontent.com/18356694/157717931-f3e3167e-0234-425a-a8eb-02303f386dc6.png)

These paths were taken straight from WinUI versions of these icons, thanks @pratikone for the alley oop.

* [x] Closes #12433
* [x] Tested manually by _lookin at it_

(cherry picked from commit b55f3ab)
@ghost
Copy link

ghost commented Apr 19, 2022

🎉Windows Terminal v1.12.1098 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Apr 19, 2022
Closed
@ghost
Copy link

ghost commented Apr 19, 2022

🎉Windows Terminal Preview v1.13.1098 has been released which incorporates this pull request.:tada:

Handy links:

@mbartlett21
Copy link

@DHowett / whoever: The [Release Notes] link done by the Bot goes to a 404.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@lhecker lhecker Awaiting requested review from lhecker

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-3 A description (P3) Product-Terminal The new Windows Terminal. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AGI-P1 Maximize icon should be rounded
4 participants
@zadjii-msft @DHowett @mbartlett21 @miniksa